remove misleading, dangerous and unneeded redefinitions (#798)

for snprintf, vsnprintf.

delete an unneeded MSVC compiler pragma.

diff --git a/defs.h b/defs.h
index 05bfa2305949a3cb31af846d8300c91525b37225..00018c65e91f2e0286e7cc70db168159380706e9 100644 (file)
--- a/defs.h
+++ b/defs.h
@@ -126,25 +126,14 @@ constexpr double KNOTS_TO_MPS(double a)  {return a * kMPSPerKnot;}
 #define CENTI_TO_MICRO(t) ((t) * 10000) /* Centiseconds to Microseconds */
 #define MICRO_TO_CENTI(t) ((t) / 10000) /* Centiseconds to Microseconds */
 
-/*
- * Snprintf is in SUS (so it's in most UNIX-like substance) and it's in
- * C99 (albeit with slightly different semantics) but it isn't in C89.
- * This tweaks allows us to use snprintf on the holdout.
- */
 #if __WIN32__
-#  define snprintf _snprintf
-#  define vsnprintf _vsnprintf
 #  ifndef fileno
 #    define fileno _fileno
 #  endif
 #  define strdup _strdup
 #endif
 
-/* Turn off numeric conversion warning */
 #if __WIN32__
-#  if _MSC_VER
-#    pragma warning(disable:4244)
-#  endif
 #if !defined _CRT_SECURE_NO_DEPRECATE
 #  define _CRT_SECURE_NO_DEPRECATE 1
 #endif